feat: add CI workflow and contributing guidelines for import rules#204
Merged
phertyameen merged 11 commits intoMindBlockLabs:mainfrom Jan 27, 2026
Merged
Conversation
phertyameen
requested changes
Jan 26, 2026
Member
phertyameen
left a comment
phertyameen
left a comment
There was a problem hiding this comment.
This is a nice setup!
But I expect you to run the test and fix the existing errors in the app too. This will definitely break existing code.
Based on your setup, some commands to run will be (run them, fix the little errors and incluse the commands in the contributing.md):
npm ci
npm --workspace frontend run build
npm --workspace backend run build
npm --workspace frontend exec -- tsc --noEmit -p tsconfig.json
npm --workspace backend exec -- tsc --noEmit -p tsconfig.jsonSample error after running the greb in the CONTRIBUTING.md
./backend/src/quests/controllers/daily-quest.controller.ts:14:import { User } from 'src/users/user.entity';
Member
|
@Obiajulu-gif have you seen my requested change? you also need to update your code. The earlier you resolve the cicd, The less errors youre likely to come accross |
Contributor
Author
|
Close #203 i have fix the issue @phertyameen |
Member
|
Unfortunately, your tests are still failing |
Member
|
@Obiajulu-gif hold on and dont change this. Let me give you some help |
yml node version upgraded, path inprovement yet path inprovement
phertyameen
force-pushed
the
feature/ci/cd_protection
branch
from
92ba27a to
5c61724
Compare
phertyameen
approved these changes
Jan 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #203
This pull request introduces new guidelines and automated checks to enforce import style and improve code quality. It adds a GitHub Actions workflow for continuous integration (CI) and documents the new import rules and branch protection requirements.
CI Workflow and Import Rules Enforcement:
.github/workflows/ci.ymlfile that defines three jobs:lint-imports: Fails the build if any absolute imports fromsrc/are found in.tsor.tsxfiles, enforcing the use of relative imports.build: Installs dependencies and builds both frontend and backend workspaces.type-check: Runs TypeScript type checks for both frontend and backend.Documentation Updates:
CONTRIBUTING.mdto:src/.lint-imports,build,type-check) and branch protection rules formainanddevelop.